[MPlayer-dev-eng] [PATCH 3/7] Use authorization field to pass server authentication through proxy

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Nov 21 16:37:34 CET 2010


On Sun, Nov 21, 2010 at 03:13:32PM +0100, Clément Bœsch wrote:
> On Sun, Nov 21, 2010 at 02:35:03PM +0100, Reimar Döffinger wrote:
> > Is far simpler.
> > Or if you want to go with your approach it should be made generic
> > in the form of a kind of "sprintf_alloc", without the URL_t argument
> > but instead e.g. a char * return value - but I think that is overkill,
> > and difficult to review (and I am still not a fan of the va_* stuff even
> > though I guess that nowadays you can expect it to work correctly).
> 
> OK I see, then I'll commit this. Do you mind a reindent of
> stream/{url,network,http}.c after this commit?

No, but I would vastly prefer if you only do a reindent, no adding
line-breaks or spaces elsewhere or anything else that would show
up in a diff -uwb and it uses 4-space indentation.


More information about the MPlayer-dev-eng mailing list