[MPlayer-dev-eng] [PATCH] Set font_fontconfig to -1 unless CONFIG_FONTCONFIG configured

[Reimar Döffinger]

On Thu, Nov 18, 2010 at 11:53:22PM +0900, KO Myung-Hun wrote:
> KO Myung-Hun wrote:
> > Reimar Döffinger wrote:
> >> On Wed, Nov 17, 2010 at 02:02:53PM +0900, KO Myung-Hun wrote:
> >>> Hi/2.
> >>>
> >>> KO Myung-Hun wrote:
> >>>> Hi/2.
> >>>> ass_configure_fontsass_configure_fonts
> >>>> font_fontconfig should be -1 if CONFIG_FONTCONFIG is not configured.
> >>>>
> >>>
> >>> If no objections, I'll apply in tomorrow.
> >>
> >> You should explain where and why it makes a difference.
> >> And possibly if the variable should be not defined at all
> >> if fontconfig is not compiled in.
> > 
> > Without this, -font and -subfont do not work when using -ass.
> > 
> > See ass_configure_fonts() in sub/ass_mp.c
> > 
> > And many codes use font_fontconfig without #ifdef guard, instead they
> > check the value of it.
> > 
> > BTW, there are inconsistencies of them. They include 0 to check if
> > fontconfig is enabled somewhere, but does not elsewhere.
> > 
> 
> Ok to commit ?

Yes. A slightly ugly but I don't see any better way.