[MPlayer-dev-eng] [PATCH 2/7] Use Proxy-Authorization instead of Authorization for proxy auth

[Clément Bœsch]

On Fri, Nov 12, 2010 at 10:40:57AM +0100, Clément Bœsch wrote:
> On Sat, Nov 06, 2010 at 11:09:23AM +0100, Reimar Döffinger wrote:
> > On Sun, Oct 24, 2010 at 09:14:17PM +0200, Clément Bœsch wrote:
> > > diff --git a/stream/network.c b/stream/network.c
> > > index 4853f87..7de834f 100644
> > > --- a/stream/network.c
> > > +++ b/stream/network.c
> > > @@ -254,7 +254,10 @@ http_send_request( URL_t *url, off_t pos ) {
> > >  	if (network_cookies_enabled) cookies_set( http_hdr, server_url->hostname, server_url->url );
> > >  
> > >  	http_set_field( http_hdr, "Connection: close");
> > > -	http_add_basic_authentication( http_hdr, url->username, url->password );
> > > +	if (proxy)
> > > +		http_add_basic_proxy_authentication( http_hdr, url->username, url->password );
> > > +	else
> > > +		http_add_basic_authentication( http_hdr, url->username, url->password );
> > 
> > As pointed out in comment to patch 3, this is possibly wrong, but at least
> > suboptimal.
> > I'd actually use a separate patch that just changes url -> server_url in
> > http_add_basic_authentication, unless there's any reason why this would
> > break anything?
> 
> No it shouldn't break anything, and after a few tests it doesn't. Also, it
> makes the Proxy-Authorization just missing instead of apparently broken.
> 
> Patches re-attached. The next step is to make both authentications working
> in the same time (patch 3 and +).
> 

If no one says anything about those two patches in the 3 next days, i'll
assume they are okay and commit them to go ahead.

-- 
Clément B.
Not sent from a jesusPhone.