[MPlayer-dev-eng] Export mp_basename in a function

Clément Bœsch ubitux at gmail.com
Mon Nov 15 13:50:12 CET 2010


On Fri, Nov 12, 2010 at 09:42:45AM +0100, Clément Bœsch wrote:
> On Fri, Nov 12, 2010 at 08:14:32AM +0100, Reimar Döffinger wrote:
> > On Thu, Nov 11, 2010 at 10:57:00PM +0100, Clément Bœsch wrote:
> > > > Also please use "const char" instead of "char" (I think
> > > > you might have to change some more code to avoid new warnings,
> > > > but I think it should be possible without real issues).
> > > 
> > > Sure, patch updated. It didn't generate a single warning.
> > 
> > The warning would come in when you do it really correctly and
> > add the const also to the return value, which I'd consider
> > preferable.
> 
> I see. Patch updated. I don't know how to test the libmenu modification,
> but it builds correctly with --enable-menu.
> 

OK to apply?

-- 
Clément B.
Not sent from a jesusPhone.


More information about the MPlayer-dev-eng mailing list