[MPlayer-dev-eng] [PATCH] Subtitles directories
Clément Bœsch
ubitux at gmail.com
Sat Nov 13 19:51:33 CET 2010
Hi,
Not a lot grudge seemed to come up when I proposed the first draft of the
subtitles directories, so here is a full working one, with documentation.
A few notes about this patch:
- It needs the basename patch to work (that should be commited soon, just
waiting for a OK.)
- I tried not to trash the existing code but I needed some
refactorization, so the diff is not quiet clear on the sub_filenames
modification (renamed in get_sub_list and set static).
- A reindent of get_sub_list will be commited after this one is accepted.
- mp_dirname is also part of the patch for a refactorization issue.
- It was suggested that -subpaths (or similar) could be more
appropriated. What do you think?
I hope the man page is clear enough about the feature. If not enough for
you developers, get_full_sub_list is quiet explanatory by itself about the
new subtitles tracking behaviour.
Please review :)
--
Clément B.
Not sent from a jesusPhone.
More information about the MPlayer-dev-eng
mailing list