[MPlayer-dev-eng] [PATCH 1/7] Unescape login/password before base64 encode

[Reimar Döffinger]

On Wed, Nov 10, 2010 at 08:02:14PM +0100, Clément Bœsch wrote:
> On Sun, Nov 07, 2010 at 11:31:50PM +0100, Clément Bœsch wrote:
> > On Mon, Oct 18, 2010 at 12:05:51PM +0200, Clément Bœsch wrote:
> > > I already sent it in a previous mail: it allows login/password to be
> > > unescaped before base64 encode so auth with special characters now
> > > works.
> > 
> > Al'right, a new version of this patch: while the form
> > 
> >   mplayer 'http://u:p@host'
> > 
> > was url encoded,
> > 
> >   mplayer 'http://host' -user u -passwd p
> > 
> > wasn't.
> > 
> > Now it's fixed.
> > 
> > Reimar, you also mentionned the url escaping may be broken, what was the
> > issue?
> > 
> > Anyway, is this version fine?
> > 
> 
> If anyone has something against this, speak now or I'll commit this one it
> in the next days.

I have the suspicion that this is wildly escaping and unescaping until
it just happens to work without any real concept.
Why does url_new not just apply escaping only to the path part?
I don't think escaping is supposed to be applied to anything else.