[MPlayer-dev-eng] [PATCH] mp3lib/dct64_sse.c: Explicitly use short versions of fist, fistp instructions

[Clément Bœsch]

On Sat, Nov 6, 2010 at 11:30 AM, İsmail Dönmez <ismail at namtrac.org> wrote:
> Hi;
>
> mp3lib/dct64_sse.c uses fist and fistp instructions without explicitly
> providing a length. Gas just maps this to the short version. Clang
> doesn't do this automatically and it shouldn't. Attached patch fixes
> this by using fists/fistps instructions explicitly.
>
> Please review & apply.

I can confirm the binary does not change here with GCC (the ASM related is
well assembled). I'm not qualified to review that stuff, but I have two
small questions:

 - clang indeed assembles it differently, but both version compiles: then,
   could you describe a bit what's wrong with current version?

 - are you sure about your patch? It seems not to apply very well:

     patching file mp3lib/dct64_sse.c
     patch unexpectedly ends in middle of line
     Hunk #2 succeeded at 310 with fuzz 1.

Regards,

-- 
Clément B.
Not sent from a jesusPhone.