[MPlayer-dev-eng] [PATCH 2/7] Use Proxy-Authorization instead of Authorization for proxy auth

[Reimar Döffinger]

On Sun, Oct 24, 2010 at 09:14:17PM +0200, Clément Bœsch wrote:
> diff --git a/stream/network.c b/stream/network.c
> index 4853f87..7de834f 100644
> --- a/stream/network.c
> +++ b/stream/network.c
> @@ -254,7 +254,10 @@ http_send_request( URL_t *url, off_t pos ) {
>  	if (network_cookies_enabled) cookies_set( http_hdr, server_url->hostname, server_url->url );
>  
>  	http_set_field( http_hdr, "Connection: close");
> -	http_add_basic_authentication( http_hdr, url->username, url->password );
> +	if (proxy)
> +		http_add_basic_proxy_authentication( http_hdr, url->username, url->password );
> +	else
> +		http_add_basic_authentication( http_hdr, url->username, url->password );

As pointed out in comment to patch 3, this is possibly wrong, but at least
suboptimal.
I'd actually use a separate patch that just changes url -> server_url in
http_add_basic_authentication, unless there's any reason why this would
break anything?