[MPlayer-dev-eng] [PATCH] RTMP seek support

[Diego Biurrun]

On Wed, May 26, 2010 at 06:41:22AM -0700, Howard Chu wrote:
> Diego Biurrun wrote:
>> On Tue, May 25, 2010 at 06:09:13PM -0700, Howard Chu wrote:
>>>
>>> Here's a patch for configure. It seems to be missing something though; if
>>> building against an external FFmpeg then really this switch will have no
>>> effect. Unless we decide to add the stream_rtmp.c as well. The code in
>>> this email has gone a bit stale
>>>
>>> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-March/063988.html
>>>
>>> and would need to be updated.
>>>
>>> --- configure	(revision 31217)
>>> +++ configure	(working copy)
>>> @@ -252,6 +252,7 @@
>>>     --enable-nemesi        enable Nemesi Streaming Media [autodetect]
>>> +  --enable-librtmp       enable RTMPDump librtmp input [autodetect]
>>
>> RTMPDump librtmp sounds redundant to me.
>
> Yeah, I probably spent more time thinking about this than any other part 
> of the patch.

:)

>>> @@ -7190,6 +7194,24 @@
>>>
>>> +echocheck "RTMPDump RTMP support (librtmp)"
>>> +if test "$_librtmp" = auto&&  test "$_network" = yes ; then
>>> +    _librtmp=no
>>> +    if $_pkg_config --exists librtmp ; then
>>> +        extra_cflags="$extra_cflags $($_pkg_config --cflags librtmp)"
>>> +        extra_ldflags="$extra_ldflags $($_pkg_config --libs librtmp)"
>>> +        _librtmp=yes
>>
>> Can you make a simple check instead of relying on pkg-config?
>
> OK. But this way if librtmp depends on other libraries (like -lssl or  
> -lgnutls) they will have to be provided explicitly with --extra-libs.

Sorry, I was being imprecise.  Falling back on pkg-config is OK, just
try without pkg-config first.

>>> +if test "$_librtmp" = yes&&  test "$_network" = yes; then
>>
>> You don't need to test _network again here.
>
> Actually it is, to catch an explicit --enable-librtmp --disable-network. 
> All of the other _network-dependent options do this check as well.

Right, keep this.

>
> --- configure	(revision 31222)
> +++ configure	(working copy)
> @@ -7194,6 +7198,23 @@
>  
> +if test "$_librtmp" = yes && test "$_network" = yes; then
> +  def_librtmp='#define CONFIG_LIBRTMP 1'
> +  inputmodules="librtmp $inputmodules"
> +else
> +  _librtmp=no
> +  def_librtmp='#undef CONFIG_LIBRTMP'
> +  _noinputmodules="librtmp $_noinputmodules"

noinputmodules

> @@ -9206,6 +9227,7 @@
>  $def_hardcoded_tables
>  $def_libavcodec_mpegaudio_hp
> +$def_librtmp
>  $def_llrint

Further down there is a section for external libs used through FFmpeg.

Diego