[MPlayer-dev-eng] [PATCH] x264encopt accepts x264 preset/tune/profile , noturbo

[Micha]

Hello everyone,

i came across the problem, that the option "b_pyramid" in -x264encopts
led to an abort of mencoder when using the very high quality options
from the mplayer documentation.

something like:
subq=6:partitions=all:8x8dct:me=umh:frameref=5:bframes=3:b_pyramid:weight_b


When i asked in the channel why this is, i acknowledged that mencoder is
lacking not only the new semantics of b_pyramid, but also new x264
features like presets and tunes.

According to the steps mentioned in x264.h I changed the code in
x264enc_set_param() to set default settings by accepting presets/tunes
and, (new) ignore the turbo setting for the 1st pass in multi-pass mode
if the new option "noturbo" is specified. Otherwise the "turbo" options
are automatically set by libx264.

It's not very much, but I think this complies to the libx264 interface.
There are probably more points in this code to be reconsidered, but I
just wanted to provide a working version to use presets. Please take
into account, that this is my first contribution and that I, most
likely, made some formal errors and/or wrote poor C code.

The patch also includes some changes for the english manpage with some
notes on presets/tunes and the change of turbo to noturbo. But this
should seriously be made by someone who knows what he or she is talking
about (like the section for b_pyramid) and not by me :)

Cheers,
  Michael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mencoder-x264-presets.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100527/151e7518/attachment.asc>