[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), Final version?

[Thomas Orgis]

Am Wed, 26 May 2010 01:47:55 +0400
schrieb Andrew Savchenko <bircoph at gmail.com>: 

> What about creating const char* for that string, and just pointing to it when necessary?

Sorry, but I fail to see how that is less complicated than just having
the condition on the handle pointer twice. It may be all a matter of
preference... but I'd still favor the version I indicated, with one
statement for the error message and, separate from that, the cleanup
code.
If there's consensus among MPlayer folks about some different form, I
don't mind.


Alrighty then,

Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100526/95b42569/attachment.pgp>