[MPlayer-dev-eng] [PATCH] introducing -vf pretend (was: removing libmpcodecs/vf_rbg2bgr.c)

Attila Kinali attila at kinali.ch
Wed May 26 09:07:28 CEST 2010


On Tue, 25 May 2010 00:28:08 +0200
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> Hmm... Surprised this actually works... I was working on extending
> -vf format to do something like this but expected it to not work...
> The "problem" I have with it is that

> > +The user is responsible that input and output formats are structurally
> > +similar. Otherwise all odd effects can occur.

> means you actually can only use it with a format filter in front, otherwise
> you can't know what will happen.

Yes. I thought this too, but didn't see any simple way to
check whether input and output formats are compatible.

Is there a way to figure out how many planes a colour format
uses (independent of what mp_image says) and what subsampling
it uses, if any?

> Another minor annoyance is that it won't automatically select the "best" RGB/BGR
> format, however I think it's reasonable to ignore that.

This could be actually solved by using classes of formats.
Ie, specify that the output is of type BGR and then select the
right one based on the given input type.

> Maybe you could have a look at what I did for -vf format and see if you think
> this might be a better solution (assuming we can get it to work)?

This might be a good idea, but doesnt solve the above problems completely.

			Attila Kinali
-- 
If you want to walk fast, walk alone.
If you want to walk far, walk together.
		-- African proverb



More information about the MPlayer-dev-eng mailing list