[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), Final version?

[Andrew Savchenko]

Hi,

On Wednesday 26 May 2010, Thomas Orgis wrote:
> Am Tue, 25 May 2010 12:52:37 +0200
> schrieb Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>: 
> 
> > To be honest, I don't know what's worse, duplicating the same string (compiler will
> > probably optimize) or testing the same condition twice. Maybe someone else has
> > a suggestion how to optimize this piece of code.
> 
> Isn't it more important here to have the least code duplication in terms of written characters?
> At least I'd opt for that. Having the same string twice for the same logical thing feels nasty.

What about creating const char* for that string, and just pointing to it when necessary?

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100526/901d4878/attachment.pgp>