[MPlayer-dev-eng] [PATCH] RTMP seek support

Howard Chu hyc at highlandsun.com
Mon May 24 23:01:38 CEST 2010


Reimar Döffinger wrote:
> On Tue, Mar 30, 2010 at 01:31:34PM -0700, Howard Chu wrote:
>> Howard Chu wrote:
>>> Reimar Döffinger wrote:
>>>>>> Now I remember why it felt so wrong: look at the existing
>>>>>> STREAM_CTRL_SEEK_TO_TIME stuff for DVDs and try to reuse it if at
>>>>>> all possible.
>>
>> Fixed up the timebase conversions, had them wrong in the previous
>> patch. Also fixed the return value from mp_read_seek.
>>
>> This also requires the ffmpeg patch I posted here:
>>
>> https://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-March/086166.html
>>
>> I haven't yet bothered with adding configure logic for librtmp here
>> since as far as I can see it's irrelevant. Nothing in this patch is
>> specific to librtmp, it's just making mplayer take advantage of
>> generic ffmpeg APIs.
>>
>> I guess we can unconditionally add rtmpt/rtmpe/rtmpte/rtmps to
>> stream_ffmpeg.c; the worst that can happen is that it'll report the
>> stream is unsupported if ffmpeg lacks the support.
>
> Does anyone have comments? Has maybe someone even tested it?
> I think it is ok to apply if it works...

It (still) works for me with a fresh SVN pull. I have not checked to see if it 
has ill side-effects for non-RTMP streams.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/



More information about the MPlayer-dev-eng mailing list