[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), Final version?

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Mon May 24 16:58:55 CEST 2010


On Sunday, 16 May 2010 at 18:03, Thomas Orgis wrote:
[...]

> Index: libmpcodecs/ad_mpg123.c
> ===================================================================
> --- libmpcodecs/ad_mpg123.c	(Revision 0)
> +++ libmpcodecs/ad_mpg123.c	(Revision 0)
[...]
> +  bad_end:
> +    if (!con->handle)
> +        mp_msg(MSGT_DECAUDIO, MSGL_ERR, "mpg123 preinit error: %s\n",
> +               mpg123_plain_strerror(err));
> +    else
> +        mp_msg(MSGT_DECAUDIO, MSGL_ERR, "mpg123 preinit error: %s\n",
> +               mpg123_strerror(con->handle));
> +
> +    if (con->handle)
> +        mpg123_delete(con->handle);

This if() can be merged with the else above.

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan



More information about the MPlayer-dev-eng mailing list