[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), Final version?

[Diego Biurrun]

On Sun, May 16, 2010 at 06:03:57PM +0200, Thomas Orgis wrote:
> Am Sun, 16 May 2010 12:10:46 +0200
> schrieb Diego Biurrun <diego at biurrun.de>: 
>  
> > Hmm, quick benchmarks on my K6-III show external mpg123 to be about
> > 20-25% slower.  What gives?
> 
> But what I could do, and what I did in mpg123 SVN, is to manage buffers
> with a minimal size of 4K instead allocating a new one for each bit of
> data that arrives. This brings the decoding time with mplayer for a set
> of reference files down to 12 seconds on my 1.2GHz Core2Duo compared to
> 12.7 seconds with mp3lib.

What set of files are you using?  We should test with the same set.

> Would you be so kind to test with a libmpg123 built from
> http://mpg123.org/snapshot ? No need to rebuild mplayer, just running
> with LD_LIBRARY_PATH is enough, as, like I said before, I intend
> libmpg123 to stay backwards compatible;-)

I built libmpg123 directly from svn and the performance difference is
much smaller but still there.  Before we go into detailed benchmarking
I think we need to find a suitable set of test samples.

Diego