[MPlayer-dev-eng] [PATCH] Support CineForm HD

[Reimar Döffinger]

On Sun, May 23, 2010 at 05:16:45PM +0200, Dan Oscarsson wrote:
> sön 2010-05-23 klockan 14:31 +0200 skrev Diego Biurrun:
> > On Sun, May 23, 2010 at 01:29:09AM +0200, Steinar H. Gunderson wrote:
> > > On Sun, May 23, 2010 at 01:25:20AM +0200, Reimar Döffinger wrote:
> > > >> +          if (data) {
> > > >> +             *data = 1000;
> > > >> +          }
> > > >> +          if (type) {
> > > >> +             *type = REG_DWORD;
> > > >> +          }
> > > >> +          if (count) {
> > > >> +             *count = sizeof(DWORD);
> > > >> +          }
> > > > Pointless {}
> > > 
> > > Is this an established MPlayer standard? It's not consistently applied even
> > > within the same file.
> > 
> > Let's say that it's one we try to establish :)
> > All those guidelines are generally applied to new files, the old
> > files are waiting for the grand refactoring..
> 
> Though the above {} need not be pointless.
> It simplifies adding code later to conditional code sections, and at
> least I think is is much clearer and easier to read.

If the surrounding code uses that style I don't really care, however in general
consistency is more important than individual preferences and the long-term goal
is to be in sync with FFmpeg.
FFmpeg style here means these variants for ifs with one-line bodys:
1)
if (a)
    b;

2)
if (a) {
    b;
} else
    c;