[MPlayer-dev-eng] [PATCH] new video filter : vf_deflicker

[Diego Biurrun]

Please don't top-post, thanks.

On Sat, May 15, 2010 at 06:28:27PM +0200, alexandre wrote:
>
> Okay, here is an updated patch.
>
> --- libmpcodecs/vf_deflicker.c	(r??vision 0)
> +++ libmpcodecs/vf_deflicker.c	(r??vision 0)
> @@ -0,0 +1,176 @@
> +/*
> + *  vf_deflicker.c

This is pointless and becomes harmful when the file is renamed
as people will invariably forget to change this.

> + *  Histogram-matching based deflicker.

s/.//

> + *  Copyright(c) 2010 Alexandre Janon <alex14fr at gmail.com>

Copyright (C) 2010 Alexandre Janon <alex14fr at gmail.com>

> + *
> + *  This file is part of MPlayer.

The above three lines you indented with two spaces instead of one.

Please use K&R style, 4 space indent, no tabs, no trailing whitespace.

> --- DOCS/man/en/mplayer.1	(r??vision 31179)
> +++ DOCS/man/en/mplayer.1	(copie de travail)
> @@ -6474,6 +6474,16 @@
>  .TP
> +.B deflicker[=10]
> +Histogram-matching based deflicker. For each video frame, it builds
> +a target histogram, based on the average of the previous frames. Then 
> +it matches histogram of the current frame with the target histogram.
> +The optional argument is the number of frames averaged during target
> +histogram creation; the correct setting depends on the frequency of 
> +the flicker you want to remove.

New sentences must be placed on new lines in the man page.

Diego