[MPlayer-dev-eng] [PATCH] Style tag support for srt and microdvd subtitles

[ubitux]

On Sat, May 15, 2010 at 12:03:04PM -0300, Kazuo Teramoto wrote:
> 2010/5/15 ubitux <ubitux at gmail.com>:
> > - Let the old filter html tags if there is ones left
> 
> I think this filter need to be improved. Because it is to greedy...
> The patch Jonatan have a better handling on this, it only strip
> "invalid" html tags. Of course is hard to determine what is a invalid
> html tag...
> 
> […]
> 
> Get displayed wrong (in my interpretation) as "The ",  Some languages
> use a ‹ › to quote, and so somebody can try to use <> as a substitute,
> and can have others uses too (for example marking different voices
> '[Alice] How are you? <phone rings>').
> 

Yeah I agree we should try to avoid the greedy code behaviour. But since
all official tags are not supported in my patch, I don't really want to
mess with them. When every tags will be supported, it will be easy to
simply remove the greedy code.

> The problem is srt dont have a spec, so is hard to define what is
> wrong and what is not. Sometime ago I see a site that give feature
> comparassion of srt rendering. Its list ass override tags as a
> feature! Clearly this is a abuse...

This site? http://ale5000.altervista.org/subtitles.htm

> Uhh and a question, I'm confused Wikipedia call the format we are
> describing as SubRip, but mplayer describe it as subviewer and what
> mplayer calls subrip is subviewer in the Wikipedia...
> 

I just kept the "subviewer" typo of mplayer, but I agree it should be
renamed. But maybe in another patch, with others cosmectics, etc; the file
is indented like hell, but let's finish the tags parsing first.

-- 
ubitux