[MPlayer-dev-eng] [PATCH] new video filter : vf_deflicker

[Carl Eugen Hoyos]

alexandre <alex14fr <at> gmail.com> writes:

> --- libmpcodecs/vf_deflicker.c	(révision 0)
> +++ libmpcodecs/vf_deflicker.c	(révision 0)
> @@ -0,0 +1,161 @@
> +/*
> + *  vf_deflicker.c
> + *  Histogram-matching based deflicker.
> + *  Copyright(c) 2010 Alexandre Janon <alex14fr <at> gmail.com>

Afaict, this makes the file not only un-redistributable, but possibly even
forbids to use it...

Before adding a GPL header (please copy it from another file), consider using
the LGPL: FFmpeg is getting a filter system atm, and at least the framework
there is LGPL.

[...]

> Index: libmpcodecs/vf.c
> ===================================================================
> --- libmpcodecs/vf.c	(révision 31179)
> +++ libmpcodecs/vf.c	(copie de travail)
> @@ -212,6 +213,7 @@
>      &vf_info_blackframe,
>      &vf_info_ow,
>      &vf_info_fixpts,
> +	 &vf_info_deflicker,

This looks wrong (tabs vs spaces).

I can't comment on the patch...

Carl Eugen