[MPlayer-dev-eng] [PATCH] Fixing dvd:// support

[Nico Sabbi]

Il martedì 11 maggio 2010 15:28:53 Olivier Rolland ha scritto:
> On Sun, May 2, 2010 at 1:09 PM, Olivier Rolland
>
> <billl at users.sourceforge.net> wrote:
> > Hi,
> >
> > Here are 3 patches to fix some issues in stream_dvd.c :
> >
> > - The first one fixes the incorrect assumption that the number of
> > chapters of a DVD title is equal to the number of cells.
> >
> > - The second one improves seeking by chapters. The current code
> > seeks to the starting position of the chapter. From this
> > position, it then tries to figure out the starting cell. This is
> > completely suboptimal and error prone since the starting cell can
> > be directly deduced from the chapter.
> >
> > - The third one improves seeking by position. The current code
> > takes the angle into account. This is a mistake since the
> > position is independent of the angle.
> >
> > Please, apply the patches in order.
> >
> > Regards,
> >
> > Olivier
>
> ping !

I gave them a quick look few days ago and they seemed to be correct; 
yet I remember that I implemented that seeking mechanism for some 
reason that -guess what?-  I don't remember.

I didn't test the code (sorry, but my work is taking away all my time) 
but my  heart says it's correct, so if it works I approve the commit.