[MPlayer-dev-eng] [PATCH] Use high-level QuickTime decoding API

Sascha Sommer saschasommer at freenet.de
Tue Mar 16 20:37:16 CET 2010


Hi,

Am Montag 08 März 2010 14:05:54 schrieb Steinar H. Gunderson:
> On Mon, Mar 08, 2010 at 09:56:11AM +0100, Attila Kinali wrote:
> >>  - Leave this decoder in its current, arguably broken state.
> >>  - Implement this change, test as thoroughly as possible (I've already
> >>    checked sample files for all QuickTime codecs I could get to work),
> >>    and watch out for regressions.
> >>  - Make a new, separate QuickTime decoder using the new API, and
> >> maintain both.
> >
> > I'm for option 2. There is no point in keeping code if it's not 100%
> > working.
> 
> I guess ultimate Sascha is the one to decide here. Sascha, are you
> comfortable with the change?
> 

I don't think I'm the best to decide here. I haven't touched the code for 
ages.
My first decoder implementation used the high level API but it only worked on 
windows because the loader could not handle the quicktime dlls back then.
We then added support for the low level API so that the SVQ3 decoder could be 
used with libwine.
Must have been somewhen around 2002...

If the loader now works with the high level API, the change that you already 
commited is probably the better solution in the long run.

Regards

Sascha






More information about the MPlayer-dev-eng mailing list