[MPlayer-dev-eng] [PATCH] Fix return value of InitializeCriticalSectionAndSpinCount

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Mar 16 07:31:39 CET 2010


On Tue, Mar 16, 2010 at 12:10:12AM +0100, Steinar H. Gunderson wrote:
> InitializeCriticalSectionAndSpinCount returns a nonzero value on success,
> and some codecs (notably VP7) seemingly got confused when it didn't, if and
> only if we tried to emulate NT or newer.
> 
> /* Steinar */
> -- 
> Homepage: http://www.sesse.net/

> Index: loader/win32.c
> ===================================================================
> --- loader/win32.c	(revisjon 30904)
> +++ loader/win32.c	(arbeidskopi)
> @@ -1412,9 +1412,10 @@
>      return;
>  }
>  
> -static void WINAPI expInitializeCriticalSectionAndSpinCount(CRITICAL_SECTION* c, DWORD spin)
> +static int WINAPI expInitializeCriticalSectionAndSpinCount(CRITICAL_SECTION* c, DWORD spin)

To be pedantic, I think the return type should be WIN_BOOL.
No objections otherwise.



More information about the MPlayer-dev-eng mailing list