[MPlayer-dev-eng] [PATCH] Support CineForm HD

[Reimar Döffinger]

On Sat, Mar 13, 2010 at 06:01:04PM +0100, Steinar H. Gunderson wrote:
> +    if (t==0) {
> +	// Hacks for CineForm.
> +	if (strcmp(c, "HKCU\\SOFTWARE\\CineForm\\DecoderProperties\\Resolution") == 0) {
> +	  *data = 1000;
> +	  return 0;
> +	}
> +	if (strcmp(c, "HKCU\\SOFTWARE\\CineForm\\DecoderProperties\\PixelFormats") == 0) {
> +	  *data = 0xffff;
> +	  return 0;
> +	}
> +	free(c);
> +	return 2;
> +    }

You're not freeing c for 2 out of 3 cases, and you are leaving type and count
uninitialized.
Can't you just add those keys properly, e.g. in the create_registry function?
We already create dummy HKLM and HKCU keys there after all.