[MPlayer-dev-eng] [PATCH] improve dvd subtitle. cmd 7 (CHG_COLCON)

A Tanaka tanahqua-aa at yahoo.co.jp
Sat Mar 13 10:03:52 CET 2010


On Wed, 10 Mar 2010 23:45:47 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> > +    this->imagebuf_size = 2 * this->image_size;
> > +    this->imagebuf = malloc(this->imagebuf_size);
> 
> This could be aligned.

> > +  if (this->image_size == 0 || this->imagebuf == NULL) {
> > +    this->height = 0;
> > +    this->image_size = 0;
> > +    this->image = NULL;
> > +    this->aimage = NULL;
> >      return;
> > +  }
> > +
> > +  this->image = this->imagebuf;
> > +  this->aimage = this->imagebuf + this->image_size;
> 
> These could be aligned as well, more below.

What does 'aligned' means? like this?
a   = 1;
bb  = 2;
ccc = 3;

If so, no such alignments are used in current spudec.c.
Do I need change my code?

thanks.
--------------------------------------
Get the new Internet Explorer 8 optimized for Yahoo! JAPAN
http://pr.mail.yahoo.co.jp/ie8/



More information about the MPlayer-dev-eng mailing list