[MPlayer-dev-eng] [PATCH] Override binary codec path
KO Myung-Hun
komh at chollian.net
Wed Mar 10 12:38:07 CET 2010
Diego Biurrun wrote:
> On Tue, Mar 09, 2010 at 10:00:37PM +0900, KO Myung-Hun wrote:
>>
>> --- get_path.c (revision 30850)
>> +++ get_path.c (working copy)
>> @@ -40,11 +40,10 @@
>> #elif defined(__CYGWIN__)
>> #include <windows.h>
>> #include <sys/cygwin.h>
>> -#elif defined(__OS2__)
>> -#define INCL_DOS
>> -#include <os2.h>
>> #endif
>>
>> +#include "osdep/osdep.h"
>
> OK. If you find more uses for the osdep.h header, commit right away.
>
Ok. Applied.
> It's still not clear to me why you implement this in an OS-specific way
> instead of adding a generic command line option.
>
You're right. Your idea is more elegant and more universal. ^^
I've introduced '-bincodecpath'.
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.0.3
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bincodecpath.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100310/26ada3d1/attachment.asc>
More information about the MPlayer-dev-eng
mailing list