[MPlayer-dev-eng] [PATCH] Support CineForm HD

[Reimar Döffinger]

On Mon, Mar 08, 2010 at 09:48:05PM +0100, Steinar H. Gunderson wrote:
> On Sat, Mar 06, 2010 at 07:35:12PM +0100, Reimar Döffinger wrote:
> > For example support both user and system-wide registry files and let whatever
> > system the distribution uses handle updating the system-wide one.
> > Or as with codecs.conf support one built into the binary.
> > Or add a version to the registry file and refuse to load outdated ones with
> > a warning.
> 
> While all of these appear to be reasonable suggestions, they do seem a bit
> overkill to me for the needs of a single codec, compared to a few lines in
> registry.c (especially when it comes to a suggestion like building a fixed
> registry into the binary, which seems pretty comparable to me).

It would be all in a single file in etc and that file could also be used as
a template for their own registry files.

> FWIW, I've attached version of the patch that checks the entire registry path
> instead of just the key name.

I think it still is not possible to overwrite those values from a custom registry
file like this.

> Index: loader/win32.c
> ===================================================================
> --- loader/win32.c	(revisjon 30866)
> +++ loader/win32.c	(arbeidskopi)
> @@ -3729,7 +3729,7 @@
>  	free(tmp);
>  	return result;
>      }
> -    if (strstr(cs1, "vp3") || strstr(cs1, ".fpf"))
> +    if (strstr(cs1, "vp3") || strstr(cs1, ".fpf") || strstr(cs1, ".col"))
>      {
>  	int r;
>  	int flg = 0;
> Index: etc/codecs.conf
> ===================================================================
> --- etc/codecs.conf	(revisjon 30866)
> +++ etc/codecs.conf	(arbeidskopi)
> @@ -1960,6 +1960,15 @@
>    guid 0xe2b7dc56, 0x38c5, 0x11d5, 0x91, 0xf6, 0x00, 0x10, 0x4b, 0xdb, 0x8f, 0xf9
>    out BGR24,BGR8 flip
>  
> +videocodec cineformhd
> +  info "CineForm HD"
> +  status working
> +  fourcc CFHD
> +  driver dshow
> +  dll "CFDecode2.ax"
> +  guid 0xAD83011E, 0x01d1, 0x4623, 0x91, 0xfd, 0x6b, 0x75, 0xf1, 0x83, 0xc5, 0xa9
> +  out UYVY
> +
>  videocodec lagarith
>    info "Lagarith Lossless Video Codec"
>    comment "http://lags.leetcode.net/codec.html, requires an MMX2 CPU."

And these parts are (somewhat) independent and could be applied already IMO.