[MPlayer-dev-eng] [PATCH] Implement a few Unicode versions of Win32 functions

Steinar H. Gunderson sgunderson at bigfoot.com
Sun Mar 7 00:12:19 CET 2010


On Sun, Mar 07, 2010 at 12:01:27AM +0100, Reimar Döffinger wrote:
> Well, maybe the WideCharToMultiByte function is the better choice
> (though I consider it a bit of a too complex function for my tastes),
> but I had this patch lying around:

Isn't your wtoa just reimplementing WideCharToMultiByte (or for that matter,
wcstomb)?

In any case, ideally all the functions should be Unicode internally, but I
doubt anyone will give their mutexes non-ASCII names.

> I don't like the duplication, something like
> char ascii_name[256];
> char *aname = NULL;
> if (name) {
>     WideCharToMultiByte()
>     aname = ascii_name;
> }
> expCreateEventA()
> 
> Seems preferable to me.

Sure, I can change to that.

/* Steinar */
-- 
Homepage: http://www.sesse.net/



More information about the MPlayer-dev-eng mailing list