[MPlayer-dev-eng] [PATCH] Fix QuickTime emulated OSErr type

Attila Kinali attila at kinali.ch
Fri Mar 5 12:02:36 CET 2010


On Thu, 4 Mar 2010 18:23:52 +0100
"Steinar H. Gunderson" <sgunderson at bigfoot.com> wrote:

> The OSErr type on Mac OS X is int16_t, not int32_t (see
> http://developer.apple.com/mac/library/documentation/QuickTime/Reference/QTRef_DataTypes/Reference/reference.html).
> The upper 16 bits will typically be something random (they're entirely
> undefined). Change the type so it's right; a few places tried to compensate
> for this by masking out the upper bits, but a few places also missed them,
> which made for unpredictable behavior.

Without having checked the files themselves, the patch looks ok.

BTW: who is the maintainer of that code?
Or is Sascha still around?

		Attila Kinali


-- 
If you want to walk fast, walk alone.
If you want to walk far, walk together.
		-- African proverb



More information about the MPlayer-dev-eng mailing list