[MPlayer-dev-eng] PATCH] conditionally mark some VCD functions as static

[Reimar Döffinger]

On Sun, Feb 28, 2010 at 12:28:46PM +0100, Reimar Döffinger wrote:
> On Sat, Feb 27, 2010 at 02:28:17PM +0100, Diego Biurrun wrote:
> > Attached patch marks another VCD-related function as static when
> > compiling without GUI support and works around the -Wmissing-decls
> > warning when the GUI is enabled.
> > 
> > I know it is supremely ugly and I would not normally propose it,
> > but I have come to think it's better to expose the GUI ugliness than
> > to sweep it under the rug.  Also, if some day the GUI is removed,
> > the ugliness goes away and the fix is remembered.
> 
> Well. I actually think this is not just a GUI ugliness, this feature
> is not available for command-line MPlayer at all!
> stream_cdda was fixed to expose this via STREAM_CTRL_SEEK_TO_CHAPTER,
> after that the gui code can either be switched to that or that part
> can just be removed.

Here's a patch for that, but due to lack of VCDs (and it being impossible to test
with VCD images) I can't test it...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vcdchapt.diff
Type: text/x-diff
Size: 1308 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100301/cf75b392/attachment.diff>