[MPlayer-dev-eng] [PATCH] [RFC] correct type for some declarations in windef

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jun 30 19:42:16 CEST 2010


On Wed, Jun 30, 2010 at 12:46:54PM +0200, Diego Biurrun wrote:
> The patch I'm attaching is a wild guess.  I know zilch about Windows
> programming, so I'm at a loss to guess the correct type.  Better
> suggestions and pointers in the right direction welcome.
> 
> This will fix a ton of the following annoying warnings:
> 
> In file included from libmpcodecs/ad_realaud.c:34:
> ./loader/wine/windef.h:304: warning: function declaration isn't a prototype
> ./loader/wine/windef.h:305: warning: function declaration isn't a prototype
> In file included from libmpcodecs/ad_realaud.c:34:
> ./loader/wine/windef.h:437: warning: function declaration isn't a prototype
> ./loader/wine/windef.h:438: warning: function declaration isn't a prototype

This is wrong, since FARPROC is supposed to be used for all kinds
of function pointers, it is not supposed to say anything about which
kinds of arguments the function takes.
My suggestion would be to comment them out (possibly with an explanation
of the issue).



More information about the MPlayer-dev-eng mailing list