[MPlayer-dev-eng] [PATCH] 1 memcpy less in lavf demuxer

[Reimar Döffinger]

On Tue, Jun 29, 2010 at 02:46:35PM +0200, Michael Niedermayer wrote:
> On Sat, Jun 26, 2010 at 08:14:27PM +0200, Reimar Döffinger wrote:
> > On Tue, Jun 22, 2010 at 11:36:39PM +0200, Michael Niedermayer wrote:
> > > +    if(pkt.destruct == av_destruct_packet){
> > >          dp=malloc(sizeof(demux_packet_t));
> > >          dp->len=pkt.size;
> > >          dp->next=NULL;
> > >          dp->refcount=1;
> > >          dp->master=NULL;
> > >          dp->buffer=pkt.data;
> > 
> > Um, won't MPlayer use free() instead of av_free() on this,
> > thus breaking on Windows?
> > I know we replaced some malloc/free with the av_ functions,
> > but not the demuxer ones I think...
> 
> hmm, then what about:

Should be ok (if you don't mind the hackishness of it), though
generally using av_malloc/av_free for the demuxer packets may
be a better long-term solution...