[MPlayer-dev-eng] [PATCH] vo_tga: fix blue channel on little endian machines

Marton Balint cus at fazekas.hu
Sat Jun 26 23:57:52 CEST 2010


On Sat, 26 Jun 2010, Reimar Döffinger wrote:
> On Sat, Jun 26, 2010 at 11:08:24AM +0200, Marton Balint wrote:
>> @@ -236,7 +196,7 @@
>>      switch(format){
>>          case IMGFMT_BGR|15:
>>          case IMGFMT_BGR|24:
>> -        case IMGFMT_BGR|32:
>> +        case IMGFMT_BGRA:
>
> Well, if your previous patch was correct, this is wrong, it should stay
> IMGFMT_BGR|32.

I think my previous patch was wrong, at the time of writing it I wasn't 
aware of the fact that IMGFMT_BGRA is endian dependent. Because of so I 
think using IMGFMT_BGRA is the correct approach. Am I missing something 
again? :)

Regards,
   Marton


More information about the MPlayer-dev-eng mailing list