[MPlayer-dev-eng] branching off rc4

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Jun 25 19:07:46 CEST 2010


On Fri, Jun 25, 2010 at 06:58:30PM +0200, Attila Kinali wrote:
> On Fri, 25 Jun 2010 16:14:32 +0200
> Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> 
> > > As it is a simple add-on and doesn't touch any other code... what
> > > about the mpg123 decoder patch I re-submitted after massive
> > > discussion, which then suddenly grew silent?
> 
> What was the conclusion of the discussion?
> (I didnt have the time to read it yet)
> 
> > If there are no serious known issues (and I'd appreciate if someone
> > else can have a quick look for anything security-relevant)
> > I think I already mentioned I am for adding it.
> 
> I'll try to have a look tomorrow.
> 
> Is the patch otherwise ok?

Well, I think there are parts that are ugly, and that it does
more than a first version should, making it unnecessarily
complex, but I guess making cleanup a prerequisite to using it
over mp3lib should serve as enough motivation to allow ignoring
that for now and commit anyway...



More information about the MPlayer-dev-eng mailing list