[MPlayer-dev-eng] [PATCH] Extra EDL command line argument

[Vlad Seryakov]

On Jun 24, 2010, at 9:24 PM, Reynaldo H. Verdejo Pinochet wrote:

> Hi Vlad
> 
> On Tue, Jun 22, 2010 at 10:26:42PM -0400, Vlad Seryakov wrote:
>> [...] 
>> 
>> ===================================================================
>> --- DOCS/man/en/mplayer.1	(revision 31528)
>> +++ DOCS/man/en/mplayer.1	(working copy)
>> @@ -1460,6 +1460,18 @@
>> on how to use this.
>> .
>> .TP
>> +.B \-edl\-backward\-extra\-sec <number>
>> +When using EDL during playback and jumping backwards it is possible to
>> +end up in the middle of an EDL record, in this case mplayer will jump out of 
> 
> I would s/this/that/ but I'm not sure.
> 
>> +the record in the same directon, to the start position of this EDL record. 
> 
> s/the record/it/
> 
>> +This parameter adds number of seconds to add to this seek so jumping out of 
> 
> Using this parameter you can set the number of seconds to add to
> the backward seek so..
> (just to avoid the adds/add in the same sentence)
> 
>> +the record will result in position a little before the start position and 
>> +will give some time to a user to press another button for going farther or
> 
> position .. position, needs to be rephrased aswell. I would also
> s/give some time to a user/give you some time/
> 
>> Index: DOCS/man/en/mplayer.1
>> +to pause. Without this extra seconds the continued after the seek playback 
> 
> _these_ extra seconds. But I would also rephrase this as:
> Without this delay the playback would.. (its kind of obvious you are refering
> to playback _after_ the seek)
> 
>> +would enter the same EDL record again and jump to the end immediately.
> 
> s/enter/jump into/ but that's just a matter of taste I guess.
> 
>> [..]
>>      CONF_TYPE_PRINT, 0, 0, 0, NULL},
>>     {"edlout", &edl_output_filename,  CONF_TYPE_STRING, 0, 0, 0, NULL},
>> +    {"edl-backward-extra-sec", &edl_backward_extra_sec,  CONF_TYPE_INT, CONF_MIN, 0, 0, NULL},
> 
> I would replace this option  and the var itself by edl-backward-delay like
> I commented on your previous patch.
> 
> Now, we really need some more peer review here. My english is far from
> perfect.
> 

Rephrased and renamed. 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: edl_patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100625/1c225c7c/attachment.txt>
-------------- next part --------------