[MPlayer-dev-eng] [PATCH] declare loader/dshow/graph.c functions in graph.h

[Diego Biurrun]

On Thu, Jun 24, 2010 at 11:25:18AM +0200, Steinar H. Gunderson wrote:
> On Thu, Jun 24, 2010 at 09:54:40AM +0200, Diego Biurrun wrote:
> >> Somehow I think I may be missing something there.  Could the
> >> functions be made static instead?
> > I will apply this after the weekend at the latest if I hear no comments.
> 
> It's fine by me, although I don't really see what the patch is supposed to
> address.

It is bad style to export functions without a prototype in scope and
gcc warns about it with -Wmissing-prototypes:

loader/dshow/graph.c:65: warning: no previous prototype for 'FilterGraph_AddFilter'
loader/dshow/graph.c:73: warning: no previous prototype for 'FilterGraph_RemoveFilter'
loader/dshow/graph.c:79: warning: no previous prototype for 'FilterGraph_EnumFilters'
loader/dshow/graph.c:85: warning: no previous prototype for 'FilterGraph_FindFilterByName'
loader/dshow/graph.c:93: warning: no previous prototype for 'FilterGraph_ConnectDirect'
loader/dshow/graph.c:102: warning: no previous prototype for 'FilterGraph_Reconnect'
loader/dshow/graph.c:108: warning: no previous prototype for 'FilterGraph_Disconnect'
loader/dshow/graph.c:114: warning: no previous prototype for 'FilterGraph_SetDefaultSyncSource'

Diego