[MPlayer-dev-eng] [PATCH] Tags support for SubRip and MicroDVD subtitles [v3]

[Kazuo Teramoto]

2010/6/19 ubitux <ubitux at gmail.com>:
>+                        /* Let's put some white in case we didn't find
>+                         * any matching colors */
>+                        tag->color = 0x00ffffff;
>+

Ubitux, this dont look correct for me, white is not a default color.
If you remember the patch I send for the web color support when it
don't found a matching color its broke the loop, this behavior set the
color for the "default one", i.e. the one current set.

And I think that we can have a more fully attribute parsing (i.e. as
described by http://www.w3.org/TR/html-markup/syntax.html#syntax-attributes
), But I think this can be done latter.

I like to say that I'm using a version of ubitux patch in daily basis
for SubRip subs with great successes, works great for all the
subtitles I used, so +1 from me.

Regards,
Kazuo

-- 
«Dans la vie, rien n'est à craindre, tout est à comprendre»
Marie Sklodowska Curie.