[MPlayer-dev-eng] [PATCH] EDL extensions, resubmit

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Mon Jun 21 22:01:48 CEST 2010


Hi Vlad

On Mon, Jun 21, 2010 at 01:27:26PM -0400, Vlad Seryakov wrote:
> I think i did not miss anything this time :-)))

Let's see ;)

> i put as a comment in the source and will also explain here:

Got it. It sounds like a command line option with a sane default
(2?) would be OK. We can leave that for latter though.

> +// Number of seconds to add to the seek when jumping out
> +// of EDL scene in backward direction. This is needed to
> +// have some time after the seek to decide what to do next
> +// (next seek, pause,...), otherwise after the seek it will 
> +// enter the same scene again and skip forward immediately
> +float edl_backward_extra_sec = 2;

Maybe edl_backward_delay? your call. Anyway, could someone confirm
this is correct Doxy? Diego? I don't recall.

> [...]
> +    // This indicates that we need to reset next EDL record according 
> +    // to new PTS due to seek or other condition
> +    if (edl_needs_reset) {
> +        edl_needs_reset = 0;
> +

Drop the extra line.

Rest looks like a keeper. Thanks.

--
Reynaldo



More information about the MPlayer-dev-eng mailing list