[MPlayer-dev-eng] [PATCH] latm faad handling

[Dan Oscarsson]

On 2010-06-17 at 22:05 +0200 Reimar Döffinger wrote:
> On Wed, Jun 16, 2010 at 09:14:05PM +0200, Dan Oscarsson wrote:
> > +    if (faac_init < 0 && sh->format == mmioFOURCC('M', 'P', '4', 'L')) {
> > +        // working LATM not found at first try, look further on in stream
> > +        for (int i = 0; i < 5; i++) {
> 
> Move the "int" out, this will not work with some older compilers.
> 
> > +            pos = sh->a_in_buffer_len-3;
> 
> This can overflow (or rather underfflow).
> 
> > +            memmove(sh->a_in_buffer, &(sh->a_in_buffer[pos]), 3);
> 
> Pointless ().
> 

Fixed in the attached updated patch.

   Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: faad-latm.diff
Type: text/x-patch
Size: 6276 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100621/0cf42614/attachment.bin>