[MPlayer-dev-eng] [PATCH] latm faad handling

Nico Sabbi nicola.sabbi at poste.it
Thu Jun 17 10:04:42 CEST 2010


Dan Oscarsson ha scritto:
> Many mpeg-ts streams with LATM do not work correctly. From what I could
> see this is because mplayer do not recognise it is LATM. In a previous
> patch I posted I added so aac_probe tried to located LATM header. This
> worked better but not for all files. I have now done further tests and
> they showed that what looks like a LATM header is not always a working
> LATM header.
>
> The following patch works for all my files with LATM or AAC audio.
>
> It does:
>
>   - libfaad2 already implements LATM header searching and verification
>     so I have added so you can call faad2's init and have it return
>     failure if LATM is not found.
>
>   - in ad_faad.c: first look for LATM using faad2,
>     if this fails and it is a mpeg-ts-stream with LATM in,
>         probe further in audio stream for LATM (tests show
>         that this is necessary),
>     if no LATM is found, do like before, probe using aac_probe
>     for a AAC stream header and call faad init.
>
>   - demux_ts.c is enhanced to recognise the AAC LATM header tag
>     so that ad_faad.c can know when to search for LATM.
>
>
>    Dan
>    
>

fine for me.
Actually it's the only solution that I could think of at the time and 
also the one I didn't want
to implement because it introduces one more fourcc for AAC, but i don't 
see another cleaner
fix.
Ok to commit if Reimar doesn't disagree.



More information about the MPlayer-dev-eng mailing list