[MPlayer-dev-eng] [PATCH] require static libswscale for mga

[Diego Biurrun]

On Wed, Jun 16, 2010 at 07:09:34PM +0200, Reimar Döffinger wrote:
> On Wed, Jun 16, 2010 at 03:18:23PM +0200, Diego Biurrun wrote:
> > On Mon, Jun 14, 2010 at 12:19:23AM +0200, Reimar Döffinger wrote:
> > > On Sun, Jun 13, 2010 at 10:52:17PM +0200, Reinhard Tartler wrote:
> > > > On Sun, Jun 13, 2010 at 13:06:26 (CEST), Reimar Döffinger wrote:
> > > > > and that is only for G200-specific code which means
> > > > > 1) disabling mga completely is very much overkill
> > > > 
> > > > mga is not disabled. Only when a static libswscale.a is disabled, in
> > > > which case linking *will* fail:
> > > > 
> > > > /vo_mga.o: In function `draw_slice':
> > > > vo_mga.c:(.text+0xcc7): undefined reference to `interleaveBytes'
> > > > libvo/vo_xmga.o: In function `draw_slice':
> > > > vo_xmga.c:(.text+0x13f7): undefined reference to `interleaveBytes'
> > > > collect2: ld returned 1 exit status
> > > > make: *** [mplayer] Error 1
> > > 
> > > The point is that all that is necessary is to disable the G200 support
> > > and it will work.
> > 
> > I suggest removing G200 support entirely then.  There are very few
> > remaining vo_mga users (I am one of them), but they will all be using
> > a G550 by now, if any G400 users remain at all, they will be very few.
> 
> Well, normally it would just be a matter of adding NV12 support for continue
> supporting it, however due to the braindead driver design (2 names for the
> same format MGA_VID_FORMAT_IYUV and MGA_VID_FORMAT_I420, but none for the
> completely different G200 format? WTF?) that's not trivial, and it would
> also be without OSD support.

I do not think continuing to support it is worth the trouble.

> And I mean only G200, G400 and above should not be affected.
> And something like attached should be enough.

This should work, commit it and remove the related configure hacks.

Diego