[MPlayer-dev-eng] [PATCH] clean up cfg-* header files

[Diego Biurrun]

On Tue, Jun 15, 2010 at 08:56:40PM +0200, Reimar Döffinger wrote:
> On Tue, Jun 15, 2010 at 10:47:39AM +0200, Diego Biurrun wrote:
> > I had another look at our cfg-*.h files that hold common and specific
> > option lists for MPlayer and MEncoder and realized that there should
> > be a way to achieve the same thing in a much simpler way: Just register
> > a separate array for the common options.
> > 
> > This gets rid of the multiple template inclusion, eliminates some
> > duplicate and generally simplifies the code.  I am happy with it.
> > 
> > I tested with MPlayer, it still accepts both common and specific
> > options.  Did I overlook something?  Otherwise I'd like to commit
> > this soon...
> 
> Well, not a big deal, but I guess you could put that new array into
> a .c file instead of into the .h?

I don't mind, but I consider that orthogonal to my patch. Also, I think
we should then put all such arrays in .c files, not just one.

Diego