[MPlayer-dev-eng] [PATCH] clean up cfg-* header files

Diego Biurrun diego at biurrun.de
Tue Jun 15 10:55:19 CEST 2010


On Tue, Jun 15, 2010 at 10:47:39AM +0200, Diego Biurrun wrote:
> I had another look at our cfg-*.h files that hold common and specific
> option lists for MPlayer and MEncoder and realized that there should
> be a way to achieve the same thing in a much simpler way: Just register
> a separate array for the common options.
> 
> This gets rid of the multiple template inclusion, eliminates some
> duplicate and generally simplifies the code.  I am happy with it.
> 
> I tested with MPlayer, it still accepts both common and specific
> options.  Did I overlook something?  Otherwise I'd like to commit
> this soon...

A few more words of explanation: I left out the deletion of
cfg-common_template.c from the patch, it's just bloat.  All of its
contents are moved into the common_opts array in cfg-common.h.

Diego



More information about the MPlayer-dev-eng mailing list