[MPlayer-dev-eng] [PATCH] require static libswscale for mga

[Reinhard Tartler]

On Sun, Jun 13, 2010 at 13:06:26 (CEST), Reimar Döffinger wrote:

> On Thu, Jun 03, 2010 at 08:18:24PM +0200, Reinhard Tartler wrote:
>> Since I don't expect anyone to actually fix the mgadrivers to actually
>> avoid swscale internals and stick to the public API, this patch makes
>> configure require a static libswscale for the mga drivers.
>
> Uh, you never mentioned which internals you mean.

I meant any external.

> Emphasis on the 's', since the only one I was able to find is interleaveBytes,

yes, I can confirm that.

> and that is only for G200-specific code which means
> 1) disabling mga completely is very much overkill

mga is not disabled. Only when a static libswscale.a is disabled, in
which case linking *will* fail:

/vo_mga.o: In function `draw_slice':
vo_mga.c:(.text+0xcc7): undefined reference to `interleaveBytes'
libvo/vo_xmga.o: In function `draw_slice':
vo_xmga.c:(.text+0x13f7): undefined reference to `interleaveBytes'
collect2: ld returned 1 exit status
make: *** [mplayer] Error 1

Fixing mga to use the public API is of course the best solution, but I
have to admit that I didn't really grok what 'interleaveBytes' does
exactly and how to call it via the libswscale public API.

> 2) we could need someone with a G200-class card to test, is such a person around
> or does everyone have G400 or newer??



-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4