[MPlayer-dev-eng] [PATCH] remove Gui mp_msg hacks

[Reimar Döffinger]

On Sat, Jun 12, 2010 at 12:18:33PM +0200, Diego Biurrun wrote:
> On Sat, Jun 12, 2010 at 09:27:45AM +0200, Reimar Döffinger wrote:
> > this will remove some hacks at the expense of the Gui no longer showing
> > any messages.
> 
> Do messages still appear on the console?

Yes.

> > Given how often the remaining users have complained about annoying/useless
> > messages this could be considered an improvement I guess...
> 
> This is incomplete, the mp_msg-mencoder* hacks could be removed at the
> same time.

Sure.

> I'm all for removing these hacks, but I see little point in keeping
> the other hacks AKA the GUI ..

The point of keeping them is to make sure we know what we are removing.
None of use uses the Gui, so we don't really know which features it has
etc.
I am not a fan of removing code without even having an idea what it does.
Also some parts may be possible to cleanup/improve more after the Gui is
gone, so I think it is a good idea to figure out where the Gui has stretched
its tendrils into before removing it.