[MPlayer-dev-eng] [RFC] Some modest proposals

[Diego Biurrun]

On Fri, Jun 11, 2010 at 07:32:53PM +0200, Reimar Döffinger wrote:
> On Fri, Jun 11, 2010 at 06:53:02PM +0200, Diego Biurrun wrote:
> > > - reformat every line of code to match ffmpeg coding style.
> > 
> > let's just run the whole code through uncrustify and be done with it.
> > Without the flames and bikeshedding please...
> 
> But please do it in a way that can be checked in a reasonable way, e.g.
> with a special svn diff command.

That is going to be hard when there are more than whitespace changes.
Of course I could run md5sum or whatever over the resulting binaries.

> Since a long time ago indent broke a piece of code for me due to not "getting"
> macros I am not willing to trust any of those programs, I wouldn't want
> to hunt a bug introduced that way.

I used uncrustify at work, it performed much better than indent for me.

I'll cook up a suitable K&R configuration for it and then present my
results.

Diego