[MPlayer-dev-eng] [PATCH] vo_tga: fix blue channel on little endian machines

Marton Balint cus at fazekas.hu
Wed Jun 9 21:16:57 CEST 2010


On Wed, 9 Jun 2010, Reimar Döffinger wrote:
> On Tue, Jun 08, 2010 at 11:00:28PM +0200, Marton Balint wrote:
>> The attached patch fixes vo_tga to set the alpha channel to 0xff
>> instead of the blue channel, and copy the blue channel data properly
>> from the source buffer.
>
> libswscale should set the alpha nowadays, so just changing the vo
> to only accept BGRA and doing fwrite without any conversion
> (i.e. removing this code piece completely) should be a better
> solution.

Ok, then how about this version? Now libswscale will do the endianness 
conversion, so I was able to remove the whole line_buff stuff.

Regards,
   Marton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_tga-fix-blue-channel-2.patch
Type: text/x-patch
Size: 2893 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100609/1982fef7/attachment.bin>


More information about the MPlayer-dev-eng mailing list