[MPlayer-dev-eng] [PATCH] require static libswscale for mga

[Reinhard Tartler]

On Mon, Jun 07, 2010 at 14:01:59 (CEST), xi wrote:

> Attila Kinali wrote:
>> On Thu, 03 Jun 2010 20:18:24 +0200
>> Reinhard Tartler <siretart at tauware.de> wrote:
>>
>>
>>> Since I don't expect anyone to actually fix the mgadrivers to actually
>>> avoid swscale internals and stick to the public API, this patch makes
>>> configure require a static libswscale for the mga drivers. It is
>>> inspired a bit by uotis mplayer-git branch, but doesn't introduce his
>>> LIBSWSCALE_INTERNALS variable. Instead, this check just checks the
>>> variable $_libswscale_a.
>>
>> If Diego is ok with the changes to configure, then i'd say
>> it's the best solution.
>>  
>>> Another option would be to just remove the mga drivers, but there still
>>> seem to be users around that actually use this.
>>
>> Yes. There are a few. But i guess, that when the last mainboards
>> with PCI interfaces disapear, that the last users of mga_vid will
>> go with them.
>>
>> 			Attila Kinali
>>
>
> I can confirm that there are still some users who uses the mga drivers:
> I am one of these them. So please don't remove it.

nobody is proposing to remove it.

The issue is that the mga drivers use internals of libswscale that are
no longer exposed in a shared libswscale.so for quite some time now. My
patch changes configure to *require* a static libswscale.a for the mga
drivers. AFAIUI, most mga users prefer this configuration for
performance reasons anyway.

However, I also note that fixing the mga drivers to use the public
libswscale API would be preferable in any case. Unfortunately, nobody
seems to be working on the mga drivers at all.

The proposed patch therefore avoids a configuration that is broken
anyway.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4