[MPlayer-dev-eng] [PATCH] Use avformat name matching rules

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Jul 27 08:49:17 CEST 2010


On Tue, Jul 27, 2010 at 02:14:01AM -0400, Alex Converse wrote:
> +static int match_format(const char *name, const char *names)
> +{
> +    int c = strcmp(name, names);
> +    return (!c || c < strlen(names) && c == strlen(name) && names[c] == ',');

I don't think the return value of strcmp means what you think it means.
Actually, it doesn't mean anything at all usually it is just the difference
between the two non-matching characters, but even that's not guaranteed.
Also, as said, I consider all this pointless as long as the meaning
of "avif->names" is not defined and thus fixed as part of the API.


More information about the MPlayer-dev-eng mailing list