[MPlayer-dev-eng] [PATCH] vobsub fix

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Jul 24 19:24:14 CEST 2010


On Wed, Jul 21, 2010 at 11:06:49AM +0800, 191919 wrote:
> 1019                                 while (queue->current_index + 1 <
> queue->packets_size
> 1020                                        &&
> queue->packets[queue->current_index + 1].filepos <= pos)
> 1021                                     ++queue->current_index;
> 
> The first two pair of queue->packets[queue->current_index + 1].filepos
> and pos are:
> 
> 20480 14
> 16384 2062
> 
> before mplayer crashes. So queue->current_index was never incremented.

Well, there is also the packet_queue_insert code.
But that one doesn't run, because the packets we are trying to
merge simply have no data that we care about.
While I'm not 100% sure there isn't another bug still there
that causes this, I am convinced this way of fixing seems right,
so I applied my variant.
Thanks for analyzing and reporting.

Reimar


More information about the MPlayer-dev-eng mailing list